search

blipson89 / Synthesis

Synthesis is a universal object mapper for Sitecore
MIT License
75 stars 25 forks source link

Images do not render from Content Hub DAM #93

Closed rkuchler closed 1 year ago

rkuchler commented 3 years ago

Do you want to request a feature or report a bug? This appears to be a bug.

What is the current behavior? When calling either the Render method or the ImageFor method on an ImageField object the image files to render if it is sourced from the DAM.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install and configure the Sitecore Connect™ for Sitecore DAM 2.0 module in a Sitecore 9.3 XP solution
  2. Add an image field to any template
  3. Create an item based on that template
  4. In the content editor edit that item and click on the Browse Sitecore DAM link to add an image
  5. Preview the item and note that the image does not render

What is the expected behavior? The image would render the same way it would if it were sourced from the media library

Please mention your Sitecore version and Synthesis version. Sitecore 9.3 Synthesis 9.1.0.2

blipson89 commented 3 years ago

Fixed in Synthesis 9.1.2

Thank you for the help @rkuchler

jroho commented 3 years ago

Do you want to request a feature or report a bug? I think this issue needs to be reopened.

What is the current behavior? This issue appears to persist when accessing Url from ContentHubImageField which is derived from IImageField :: FileField. I followed the instructions to implement ContentHubImageField, but there appears to be issues accessing Url, which is inherited from Synthesis.FieldTypes.Interfaces.IFileField, and IImageField. It's always null for images set from Content Hub.

If the current behavior is a bug, please provide the steps to reproduce.

  1. Install and configure the Sitecore Connect™ for Sitecore DAM 2.0 module in a Sitecore 9.3 XP solution
  2. Add an image field to any template
  3. Create an item based on that template
  4. In the content editor edit that item and click on the Browse Sitecore DAM link to add an image
  5. Preview the item and note that the image does not render
  6. Url property is always null for the ContentHubImageField (We don't use Render() or ImageFor() as we have a custom library that inherits from IImageField)

What is the expected behavior? I would expect to be able to access data member, Url, from ContentHubImageField, derived from IImageField :: IFileField. I also added IsContentHub property to the IContentHubImageField interface. This property is useful when exposed here.

My pr does solve the issue for us (we are fully integrated with content hub), if you want to take a look: #97

Please mention your Sitecore version and Synthesis version. Sitecore 9.3 Synthesis 9.1.0.2

blipson89 commented 2 years ago

Hi @jroho,

It looks like a potential fix was released a while ago but I forgot to follow up. Is this issue resolved?

Thanks, Ben

jroho commented 1 year ago

Hey Ben,

Yep, already using it on a newer project. Working as intendended without the need to override your dll.

Thanks, Jesse

On Sat, Apr 23, 2022, 10:06 AM Ben Lipson @.***> wrote:

Hi @jroho https://github.com/jroho,

It looks like a potential fix was released a while ago but I forgot to follow up. Is this issue resolved?

Thanks, Ben

— Reply to this email directly, view it on GitHub https://github.com/blipson89/Synthesis/issues/93#issuecomment-1107517808, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALJHDMWB53UYS4VTH4PJ3LVGQGYJANCNFSM45JK5CTQ . You are receiving this because you were mentioned.Message ID: @.***>

blipson89 commented 1 year ago

Glad to hear it! I'm going to close this issue out then.