search

blipson89 / Synthesis

Synthesis is a universal object mapper for Sitecore
MIT License
75 stars 25 forks source link

Fix up Sitecore types emitted by CodeDomGenerator to use global references #99

Closed mattbarry closed 3 years ago

mattbarry commented 3 years ago

This PR fixes up all of the emitted Sitecore types to use global namespace references as per issue #98.

The same thing could be done with the Synthesis types, but I wanted to keep this PR focused on the original issue. I'd be happy to open up another PR to fix up Synthesis types. I noticed in some places they use global references and in some places they don't.

blipson89 commented 3 years ago

Looks good at first glance. I'll test it out this weekend for the release next week.

While I appreciate it, I'd like to leave the Synthesis types as they are right now so that it's consistent with it's Synthesis.csx counterpart in Leprechaun.

Leprechaun already has the Sitecore namespaces in the global:: scope.