search

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
328 stars 61 forks source link

Remove scrollbar from being a control #534

Open dlamkins opened 2 years ago

dlamkins commented 2 years ago

Having the scrollbar be its own control has caused problems. Most notably with us binding its size and position to the side of the container.

Plan is to split this implementation out as part of the container. Perhaps in a similar spirit to how the LoadingSpiralUtil works, but for the most part containers

entrhopi commented 2 years ago

392 should be considered when refactoring scrollbar

dlamkins commented 2 years ago

Good catch. 👍

entrhopi commented 2 years ago

I noticed (aside from other issues I have with the scrollbar) that, if we set ShowBorder = false the scollbar will be invisible too. Is that expected behavior?

entrhopi commented 2 years ago

This should be considered too: https://github.com/blish-hud/Blish-HUD/blob/dev/Blish%20HUD/Controls/Panel.cs#L266-L267