search

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
311 stars 60 forks source link

BlockSequenceFromGw2 cannot undo if only PrimaryKey in Keybinding #617

Open bennieboj opened 2 years ago

bennieboj commented 2 years ago

Enabling BlockSequenceFromGw2 for Keybinds with only a PrimaryKey works, but undoing doesnt. If modifiers are included it works as expected

https://github.com/blish-hud/Blish-HUD/blob/3d2835d54fdcc1a56dc9ea2d90484e84e4c3d7d6/Blish%20HUD/GameServices/Input/Keyboard/KeyBinding.cs#L108-L125 https://discord.com/channels/531175899588984842/534490472224391169/947545310329204778

bennieboj commented 2 years ago

Not needed anymore I think.

dlamkins commented 2 years ago

I'm gonna keep it open a tad longer just so that I can review our options with everything in mind. Thank you, though!