search

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
320 stars 59 forks source link

Delete module folders on clearing settings #865

Open Tharylia opened 1 year ago

Tharylia commented 1 year ago

This PR aims to clear all files of modules that currently remain when deleting the module settings.

Some modules use external json files to save some states. These states currently do not get deleted when clicking "Delete module settings" sometimes causing problems.

This PR will break module settings from certain developers choosing to use bundled folders: image

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dlamkins commented 8 months ago

Due to the existence of bundled settings, I don't think I'll be able to move forward with this particular implementation. I'm going to keep this open, though, as it would be nice if we find a suitable alternative.