blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
311 stars 60 forks source link

feat: add panel header icon #906

Closed agaertner closed 3 months ago

agaertner commented 11 months ago

Adding a minor optional title icon to panel as it has been often suggested in the Discord. I've actually done this through reflection in Proof Logix because I didn't want to copy the entire class. https://github.com/agaertner/bhm-proof-logix/blob/main/src/Core/UI/FlowPanelWithIcon.cs

Usage example: image

Example:

Is this a breaking change?

No

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dlamkins commented 6 months ago

I'm willing to accept this as a feature. Could you take a look at the spacing used in the Characters module, though? It seems a bit tighter there and I think I prefer it.

image

agaertner commented 6 months ago

I'm willing to accept this as a feature. Could you take a look at the spacing used in the Characters module, though? It seems a bit tighter there and I think I prefer it.

image

It looks 2 pixel closer to the left edge. I will move it.

EDIT: I adjusted it to match the padding in your example (source).

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 3 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 6%)

See analysis details on SonarCloud