blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
328 stars 61 forks source link

style: add menu click sounds from the game's menu. #907

Closed agaertner closed 6 months ago

agaertner commented 1 year ago

Menu click sounds for the MenuItems. 1:1 like of the original menu of the game.

Not playing for checkable menu items.

The sounds will end up in many modules otherwise. Menus like the following would get a huge boost in feel.

image

Is this a breaking change?

No

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

dlamkins commented 9 months ago

I like this. I see the files are added to both ref and content, though. I'm looking to slowly start reducing what we have in content and move it to the ref. Would it be possible to have them only in the ref?

agaertner commented 9 months ago

I like this. I see the files are added to both ref and content, though. I'm looking to slowly start reducing what we have in content and move it to the ref. Would it be possible to have them only in the ref?

Sure. I will check.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud[bot] commented 6 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 6%)

See analysis details on SonarCloud