blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
311 stars 60 forks source link

Label.ShadowColor does not affect Label.StrokeText #943

Open Taschenbuch opened 4 months ago

Taschenbuch commented 4 months ago

observed behavior:

Stroke color seems to be always Black even when Label.ShadowColor is set to Color.White.

expected behavior:

Note from freesnow

I think technically the description on the property is just wrong. There doesn't appear to have ever been an attempt to actually have ShadowColor impact the stroke color.

https://github.com/blish-hud/Blish-HUD/blob/651dee4aae362b55b2a49ec694877ac9f5534f51/Blish%20HUD/_Extensions/SpriteBatchExtensions.cs#L196

Examples:

with strokeText

new Label
{
    Text           = text,
    TextColor = Color.Black,
    StrokeText = true,
    ShadowColor = Color.White,
    AutoSizeHeight = true,
    AutoSizeWidth  = true,
    Parent         = parent
};

image

image

same without strokeText

new Label
{
    Text           = text,
    TextColor = Color.Black,
    AutoSizeHeight = true,
    AutoSizeWidth  = true,
    Parent         = parent
};

image

relevant discord chat

https://discord.com/channels/531175899588984842/536970543736291346/1213597398635520050

dlamkins commented 4 months ago

Note to self: Probably best to update the description and consider making a new property for the stroke color. Granted, they (stroke + shadow) should be mutually exclusive, so a shared property makes sense, but it is confusing. 🤔