search

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
328 stars 61 forks source link

#945 Add utc offset to log timestamps #946

Closed Tharylia closed 6 months ago

Tharylia commented 7 months ago

This PR adds the timezone information to the log timestamps.

The new format results in timestamps like this: 20:03:20.03 +01:00 | INFO | Blish_HUD.Program | Running PreRelease "local-dev"

Discussion Reference

All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:

https://discord.com/channels/531175899588984842/536970543736291346/1216456887579574363

Is this a breaking change?

Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.

No, except someone parses the log in a way that breaks with the new syntax

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dlamkins commented 6 months ago

Thanks. I'll need to get Kudu updated - I want him to spit out adjusted timestamps using Discord's time format feature.