search

blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
311 stars 60 forks source link

feat: add ModuleLoaded event to ModuleManager #958

Closed Flyga-M closed 3 months ago

Flyga-M commented 3 months ago

Pass on the Module.ModuleLoaded event to a new ModuleManager.ModuleLoaded event, when the module is enabled.

This makes it easier to ensure load order for dependent modules when accessing the parent module. Right now there's no straightforward way of doing this. Related to #923.

Just because i stumbled over it, there is also a one line fix in here: fix: set ModuleDisabled to null when disposing ModuleManager

Discussion Reference

All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:

https://discord.com/channels/531175899588984842/599270434642460753/1228126988640718858

Is this a breaking change?

Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.

No

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud