blish-hud / Blish-HUD

A Guild Wars 2 overlay with extreme extensibility through compiled modules.
https://blishhud.com
MIT License
311 stars 60 forks source link

fix: fix panel header icon texture check #960

Closed Flyga-M closed 3 months ago

Flyga-M commented 3 months ago

Fixes a potential crash, where the AsyncTexture2D Panel._icon is not null, but it's internal AsyncTexture2D._activeTexture2D is null.

This may happen if

Discussion Reference

All new features must be discussed prior to code review. This is to ensure that the implementation aligns with other design considerations. Please link to the Discord discussion:

PM discussion

Is this a breaking change?

Breaking changes require additional review prior to merging. If you answer yes, please explain what breaking changes have been made.

No

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dlamkins commented 3 months ago

Thank you!