blish-hud / Community-Module-Pack

MIT License
5 stars 25 forks source link

Fetch all floors for Universal Search to get full list #127

Closed cheahjs closed 2 years ago

cheahjs commented 2 years ago

Previously, the module would call Gw2ApiManager.Gw2ApiClient.V2.Continents[1].Floors[1], which would only get floor with ID 1, missing all of the other floors (floor IDs range from -57 to 68), which resulted in missing landmarks.

Instead, fetch all the floors, which will return all the nested subresources for that floor (as per the API docs on the wiki). To keep some form of loading indicator, fetch each floor individually (although the first few floors are the largest).

Example of Heart of the Cauldron which is at floor -38. 0.6.0: image

This PR: image

dlamkins commented 2 years ago

Thank you!