Closed Denrage closed 2 years ago
This is looking fantastic!
This looks absolutely fantastic. Should be just about ready to merge. I want to just have it get some tests to be sure.
In the meantime, do you mind modifying the manifest file to reflect this as version v0.7.0 of the module?
Totally forgot two things additional to the manifest that still needs to be taken care off
This will make the Universal Search Module more generic, so it can support different kinds of searches.
There is now a SearchHandler and a SearchResultItem for every SearchType which handles the differences between the types. The search handler can be selected through a combobox next to the search bar and later on also be selected through writing a prefix before the search term.
Example how it currently looks and works: https://s.denrage.goip.de/3eMCiCYwfww8bjN/direct
After the general idea is approved, the to do list will be worked on.Things to do:
Split PvP and PvE and determine which one is meant automaticallydoenst matter because api isnt splitting its One Wo
-l Divinit
)Add Items (maybe with local caching?)Way too big for this PR. The caching would need changes inside blishhud itself and the search would need to be async at least. Also it's still debateable if a complete ui rework would need to be doneHero Points, Hearts, Vistas, etc.- Not usefull, bc they either dont have a name or a relevant/working chat codeAdditional Tooltip windows for associated skills for traitsWill be done separately