search

blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 10 forks source link

Support rotation of 0deg #17

Closed dlamkins closed 3 years ago

dlamkins commented 3 years ago

Right now rotation of each axis is considered static if it is any value other than 0. This means that it's not possible to statically set a rotation on all axis as 0 (i.e. rotation="0,0,0" would not result in a static marker). Any minor variation is enough to lock it (e.g. rotation="0.01,0,0").

It's a minor edge case, but enough it's caused confusion in the past. Explicitly setting the attribute to 0 and the default pathable state should be distinct).

Relevant sections: Where the attribute(s) is/are loaded: https://github.com/blish-hud/Pathing/blob/0655d207e6dcc41508686b6fad5e5c262f824c5c/Entity/_StandardMarkerLoaders/Populate/StandardMarker%5Bxpos%2Cypos%2Czpos%5D.cs#L20-L31

Where the rotation is applied: https://github.com/blish-hud/Pathing/blob/0655d207e6dcc41508686b6fad5e5c262f824c5c/Entity/StandardMarker.World.cs#L52-L61

dlamkins commented 3 years ago

I'm marking this under consideration instead of as a bug as we may use this as a feature with the editor.

dlamkins commented 3 years ago

This has now been taken care of. Rotation is nullable.