search

blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 10 forks source link

Resolve marker scale offset/drift. #4

Closed dlamkins closed 3 years ago

dlamkins commented 3 years ago

Markers are currently drawn at what appears to be slightly the wrong scale causing anything except for the center of the map to be drawn in the correct spot.

Relevant code: The control which facilitates drawing on the compass and full screen map. https://github.com/blish-hud/Pathing/blob/0655d207e6dcc41508686b6fad5e5c262f824c5c/UI/Controls/FlatMap.cs#L120-L140

The code which draws markers on the above control. https://github.com/blish-hud/Pathing/blob/0655d207e6dcc41508686b6fad5e5c262f824c5c/Entity/StandardMarker.MiniMap.cs#L15-L55

The code which draws trails on the above control. https://github.com/blish-hud/Pathing/blob/0655d207e6dcc41508686b6fad5e5c262f824c5c/Entity/StandardTrail.MiniMap.cs#L16-L33

dlamkins commented 3 years ago

https://github.com/blish-hud/Pathing/pull/21/files#diff-9320cfdb4d87ed2a3591f32414247068c3898a5154e18a490079edf48ce97a82R125

Fixed. We should still work to identify why there is this error in the scaling reported (or how it is applied), but in any case, this has resolved our issue.