blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 11 forks source link

Strip markup from achievement tooltips #63

Closed Pluckerpluck closed 2 years ago

Pluckerpluck commented 2 years ago

Fixes #27

Removes the color tags from achievement descriptiosn and requirements. It uses the same regex that GW2Efficiency does (modified slightly for C#), so should catch all cases.

It also converts <br> tags into \n.

However, when it finds multiple it only ever uses a single newline. This is what GW2Efficiency does and is a choice. image Originally "Look what I can do" was an extra line down. And it's with these single line quotes that the <br><br> combo tends to be used.

There are some achievements that use multiple \n, which I haven't crushed into a single line. Weirdly, I find their use cases to be more reasonable: image

Anyway, happy to change or modify this. Just let me know.

dlamkins commented 2 years ago

I like it and am happy how the ones look that use the double \n. Looks nice.

Thank you!