blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 11 forks source link

Marker Module: List view overflows available viewport space #66

Closed dinckelman closed 2 years ago

dinckelman commented 2 years ago

As the module is configured now, it's impossible to see the complete list of TacO style markers, if the list is too long. Unavailability of a scrollbar makes the list render beyond what the available screen space is. Example of the issue.

dlamkins commented 2 years ago

Hello @dinckelman!

While we did consider adding a scrollbar for some time, the reality is that we don't want to encourage highly complex category setups which can be incredibly confusing for users to navigate efficiently.

Instead, we make use of our category filtering feature which it appears you've disabled. This feature hides all of the irrelevant categories (identified based on if they contain any markers or trails for your current map). This significantly reduces the number of category entries and makes navigation through categories far easier.

This feature can be enabled in the first tab of your Pathing Module Settings > Show Categories from All Maps.

https://blishhud.com/docs/markers/overview/managingmarkers#simplified-menus

That all being said, we may someday still add a scrollbar or another solution, but at this time it is not planned. Since this is related to the pathing module, I'm going to move this issue over to that repo.

Pluckerpluck commented 2 years ago

While a scrollbar shouldn't be necessary and is quite messy, it might be worth implementing the standard dropdown logic that can be found in other software. Take firefox as an example.

The standard dropdown menu looks as follows. It follows the same logic as Blish-HUD. Expand out, with the top element being inline with the mouse cursor:

image

However look what happens if you open that same thing at the bottom of the screen:

image

It shifts itself upwards until it fits.


So a potential partial solution to this issue, that somewhat but not fully solves the problem, would be to shift menus in the same way the Firefox does (capped such that they can never go off the top of the screen). This would at least cover the more common sitaution of nesting a couple of longer menus.

Just an idea. I myself use the simplified menus (and that's actually one of the reasons I moved over to using Blish) so I'm in no rush to start messing with this myself given that there's already a way to avoid the issue.

dlamkins commented 2 years ago

We actually do this partially already. We don't do partial shifts, but the menu will flip either upwards or downwards if it realizes it will get cut off depending on which would show more.

I do like the idea of the partial shift to help with that even more and I don't expect it would be a difficult thing to add in to the shifting logic. I'll give it a poke sometime soon and see how it goes.

Like you said. Not a huge problem solve, but a minor improvement nonetheless.

darkstar commented 2 years ago

Still doesn't work properly for the Festivals category in REactif, as this doesn'T have sub-categories for each festival: image

scrolling the list with the mouse-wheel could be an alternative that doesn't involve adding a scrollbar....

dlamkins commented 2 years ago

Yes, we are aware that this is still an issue for some category arrangements. That's why the issue remains open. 👍

flowerbot commented 2 years ago

Glad this issue is still open. Added something to previous closed issue here. If you want another example to test, try 'token collector' at Ember Bay. https://github.com/blish-hud/Blish-HUD/issues/366#issuecomment-1027653312 . As I suggested there, a simple temp improvement would be to add a 'hide completed' toggle.

dlamkins commented 2 years ago

Glad this issue is still open. Added something to previous closed issue here. If you want another example to test, try 'token collector' at Ember Bay. blish-hud/Blish-HUD#366 (comment) . As I suggested there, a simple temp improvement would be to add a 'hide completed' toggle.

Could you please confirm that you're using the latest version of the Pathing module and send a screenshot of this happening? We've introduced a fix for this more recently which helps to ensure that they stay on screen and have provided an option to scroll top and bottom of the list so I don't believe this is an issue anymore.

dlamkins commented 2 years ago

@flowerbot just checking to see if you have any updates for the above question? I want to make sure there are no further issues.

dlamkins commented 2 years ago

A method to scroll the menus was added several versions ago so I will go ahead and close this issue. If there are any further issues, please don't hesitate to let us know. 👍