blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 11 forks source link

Support for repeatable achievements #74

Closed mavinger closed 2 years ago

mavinger commented 2 years ago

Achievements that allow repeating continue to hide markers after achievement resets.

Illuminating Seitung Province (id: 6239)

Usage of the flags IgnoreNearlyComplete and Repeatable may help with this. Possible to determine if the achievement is repeatable then provide an option to the user to Show Repeatable Achievements?

{
  "id": 6239,
  "name": "Illuminating Seitung Province",
  "description": "May each lantern you light spark happiness within you, not only in the completion of the task, but through the act of lighting the world.",
  "requirement": "Transfer power to  jade lanterns at points of interest in Seitung Province.",
  "locked_text": "",
  "type": "Default",
  "flags": [
    "IgnoreNearlyComplete",
    "Repeatable",
    "Permanent"
  ],
  "bits": [
    {
      "type": "Text",
      "text": "Painter's Platform"
    },
    {
      "type": "Text",
      "text": "Aurene's Enclave"
    },
    {
      "type": "Text",
      "text": "Dreary Caves"
    },
    {
      "type": "Text",
      "text": "Aetherblade Flagship Wreckage"
    },
    {
      "type": "Text",
      "text": "Royal Court"
    },
    {
      "type": "Text",
      "text": "Secured Gate"
    },
    {
      "type": "Text",
      "text": "Monastery Temple"
    },
    {
      "type": "Text",
      "text": "Obstacle Course"
    },
    {
      "type": "Text",
      "text": "Imperial Overlook"
    },
    {
      "type": "Text",
      "text": "Bell Passage"
    },
    {
      "type": "Text",
      "text": "Town Outskirts"
    },
    {
      "type": "Text",
      "text": "Fishing Village"
    },
    {
      "type": "Text",
      "text": "Village Waypoint"
    },
    {
      "type": "Text",
      "text": "Valor Shrine"
    },
    {
      "type": "Text",
      "text": "Spirit Vestibule"
    },
    {
      "type": "Text",
      "text": "Zen Daijun Temple"
    },
    {
      "type": "Text",
      "text": "Seitung Prison"
    },
    {
      "type": "Text",
      "text": "Cat Island"
    },
    {
      "type": "Text",
      "text": "Hollow Caves"
    },
    {
      "type": "Text",
      "text": "Benyo's Expedition Renown Heart"
    },
    {
      "type": "Text",
      "text": "Fishing Hamlet"
    },
    {
      "type": "Text",
      "text": "Naga Domain"
    },
    {
      "type": "Text",
      "text": "Derelict Temple"
    },
    {
      "type": "Text",
      "text": "Harbor Market"
    },
    {
      "type": "Text",
      "text": "Serene Pool"
    },
    {
      "type": "Text",
      "text": "Provisional MinSec Camp"
    },
    {
      "type": "Text",
      "text": "Emperor's Watchtower"
    },
    {
      "type": "Text",
      "text": "Abandoned Lighthouse"
    },
    {
      "type": "Text",
      "text": "Eastern Aetherblade Crash Site"
    },
    {
      "type": "Text",
      "text": "Xunlai Jade Junkyard"
    },
    {
      "type": "Text",
      "text": "Joon's Mansion"
    },
    {
      "type": "Text",
      "text": "Ministry of Transit"
    },
    {
      "type": "Text",
      "text": "Daigo Ward Waypoint"
    },
    {
      "type": "Text",
      "text": "Jade Memorial"
    },
    {
      "type": "Text",
      "text": "Northern Aetherblade Crash Site"
    },
    {
      "type": "Text",
      "text": "Aetherblade Refuge"
    },
    {
      "type": "Text",
      "text": "Haiju Docks Waypoint"
    },
    {
      "type": "Text",
      "text": "Fish Hatchery"
    },
    {
      "type": "Text",
      "text": "Western Aetherblade Crash Site"
    },
    {
      "type": "Text",
      "text": "Training Grounds Renown Heart"
    },
    {
      "type": "Text",
      "text": "Combat Arena"
    },
    {
      "type": "Text",
      "text": "Sizhou Hall Renown Heart"
    },
    {
      "type": "Text",
      "text": "Sizhou Hall"
    },
    {
      "type": "Text",
      "text": "Monastery Waypoint"
    },
    {
      "type": "Text",
      "text": "Drizzle Cove"
    },
    {
      "type": "Text",
      "text": "Sensali Shrine"
    },
    {
      "type": "Text",
      "text": "Tengu Alpine Camp"
    },
    {
      "type": "Text",
      "text": "Shrine of Reverence"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Training Mech"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Cliffside Bell"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Old Bell"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Bloom of Seitung"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Village Overlook"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Theater Overlook"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Dog Statue"
    },
    {
      "type": "Text",
      "text": "Hero Challenge: Source of the Springs"
    }
  ],
  "tiers": [
    {
      "count": 56,
      "points": 2
    }
  ],
  "point_cap": 2,
  "rewards": [
    {
      "type": "Item",
      "id": 97213,
      "count": 1
    }
  ]
}
dlamkins commented 2 years ago

This seems reasonable. 👍

dlamkins commented 2 years ago

I apologize for not replying sooner. We pushed out a recent change which I believe should have resolved this issue. Would you perhaps be able to confirm with a recent version of the pathing module if it works as you would expect it to?

mavinger commented 2 years ago

Looks to be working now! Thanks!

dlamkins commented 2 years ago

Thanks for confirming that for us. Have a good one!