blish-hud / Pathing

[Module] The official pathing module which adds marker and trail support to Blish HUD.
https://blishhud.com/docs/markers/
MIT License
13 stars 11 forks source link

Locked packs fail to update #83

Closed dlamkins closed 8 months ago

dlamkins commented 1 year ago

Appears to be occurring when a pack is loading and attempts to update at the same time. Our test to see if we're still loading packs doesn't appear to be working well enough so we still see a lot of this:

07:51:33.2396 | WARN  | BhModule.Community.Pathing.Utility.PackHandlingUtil | Failed moving marker pack Tekkit's All-In-One from C:\Users\****\AppData\Local\Temp\optimized-207a43cd-8318-40cb-827a-9f2cd34c3aee to C:\Users\****\Documents\Guild Wars 2\addons\blishhud\markers\tw_ALL_IN_ONE.taco.
System.IO.IOException: The process cannot access the file 'C:\Users\****\Documents\Guild Wars 2\addons\blishhud\markers\tw_ALL_IN_ONE.taco' because it is being used by another process.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.File.InternalDelete(String path, Boolean checkHost)
   at BhModule.Community.Pathing.Utility.PackHandlingUtil.<BeginPackDownload>d__5.MoveNext() in C:\BhApps\BhudRequestFor\work\X9MTOEsOzU2nGFtzofBhFA\Utility\PackHandlingUtil.cs:line 150

We see a message shortly after this:

07:51:50.7402 | INFO  | BhModule.Community.Pathing.PackInitiator | Finished loading packs +abaddon[64ms], +HeartZones[0ms], +hero.blish.pack[10ms], +RACE_BeetleTracks[0ms], +reactif.en[54ms], +TehsTrails[7ms], +TwistedCastle[0ms], +tw_ALL_IN_ONE[216ms], -RACE_BeetleTracks[81ms], -markers[726ms] in 1503ms for map 1206.

Confirming that packs were still loading when it attempted to do the update.