search

blittle / backbone-nested-models

Backbone Nested Models
86 stars 28 forks source link

Set underscore as a local #25

Closed mittsh closed 9 years ago

mittsh commented 9 years ago

Passed underscore as a local variable of the factory, fixing import with CommonJS or Node. The same way Backbone was passed as a parameter of factory(), this adds _ (Underscore.js).

Before this change, this fails us as we're trying to run Backbone + Backbone Nested Models in Node.js. All works fine except this detail.

Thanks for considering to merge this! I didn't bump the version number, let me know if you'd like to do so (I think it should be, but didn't want to make that decision on my own, probably v2.0.1 would be good).

mittsh commented 9 years ago

@blittle thanks for the super quick merge, that's awesome :+1:

blittle commented 9 years ago

@mittsh thank you!