Closed alexfinnarn closed 3 years ago
That's weird. #39 hasn't been merged yet, and I doubt it's related. Maybe Heroku's npm install
just failed ... Does the issue still persist?
package.json and package-lock would be very interesting, indeed.
npm install
finishes and it's a Next.js project with npm run build
also...I use Yarn but Heroku might switch to npm...but if you're familiar with Heroku, the "build" phase and generated "slug" are fine, it's in the run-time "npm run start" that fails.
I have this repo public, so easy to share...
https://github.com/CUCentralAdvancement/cms/blob/main/package.json https://github.com/CUCentralAdvancement/cms/blob/main/yarn.lock
TSconfig.json might also be in play with the ejs vs common module loading option?
https://github.com/CUCentralAdvancement/cms/blob/main/tsconfig.json
@alexfinnarn sounds like you need to move babel-plugin-superjson-next
from a dev dependency to a regular dependency. 🤔
That should help 👍 @alexfinnarn feel free to re-open if that doesn't help :)
Thanks, changing that did help!...although I had some other minor code things I needed to update as well for my deployment to not break.
I guess I copied the install command wrong and thought all Babel dependencies go in devDependencies
since that's where I have @babel/core
. Should I move @babel/core
out of a dev dependency?
The issue can remain closed and might help someone else...I just had that follow-up question since I clearly don't know much about using Babel.
devDependencies vs dependencies is basically a trash situation for apps. They don't really make a difference in most cases. The difference is mainly effective for libraries.
Locally, I don't see any issues, but after I build my project on Heroku, I get this error:
I can provide more logs, package.json, etc if needed. Might be related to https://github.com/blitz-js/babel-plugin-superjson-next/pull/39#issuecomment-776962782