Open abuuzayr opened 3 years ago
@abuuzayr sounds great to me!
was wondering if you're converting the files to TypeScript how are you splitting what needs to be done first? @abuuzayr
thanks @Mvrs would there be any issue if we started anywhere in particular? Sorry, I'm not a well-versed Typescript user..
Probably if there are common/shared types we will need to declare them somewhere first?
@abuuzayr I think first making sure the config files down to the lint tools support ts, tsx file types. Looking at the files that share common types, hooks, and etc.
ah, i get what you mean. when this issue was created, TS was set up but as of this commit 1f9d0935a1795114c5aea6dde081c72a6fa0d516 they were removed.
so yup you are right, we will have to set it all up again if we wish to use TS.
Interesting... I wonder why the reason to move away from TypeScript before.
@JuanM04 why did you remove tsconfig awhile back?
@flybayer because it wasn't being used. I changed it for a jsconfig knowing that we could recover it with Git
Since the initial setup of the V2 site was based on the tailwindcss.com repo, TS is not used. However, @cwray-tech did set it up when converting it to a Blitz repo.
In the spirit of keeping to Blitz.js's style, I think TS should be used.
.js
files to.ts
.js
files that requirejsx
tags to.tsx