blitz-js / blitzjs.com

Website & docs
https://blitzjs.com
MIT License
180 stars 328 forks source link

V2 - Use Typescript #324

Open abuuzayr opened 3 years ago

abuuzayr commented 3 years ago

Since the initial setup of the V2 site was based on the tailwindcss.com repo, TS is not used. However, @cwray-tech did set it up when converting it to a Blitz repo.

In the spirit of keeping to Blitz.js's style, I think TS should be used.

cwray-tech commented 3 years ago

@abuuzayr sounds great to me!

Mvrs commented 3 years ago

was wondering if you're converting the files to TypeScript how are you splitting what needs to be done first? @abuuzayr

abuuzayr commented 3 years ago

thanks @Mvrs would there be any issue if we started anywhere in particular? Sorry, I'm not a well-versed Typescript user..

Probably if there are common/shared types we will need to declare them somewhere first?

Mvrs commented 3 years ago

@abuuzayr I think first making sure the config files down to the lint tools support ts, tsx file types. Looking at the files that share common types, hooks, and etc.

abuuzayr commented 3 years ago

ah, i get what you mean. when this issue was created, TS was set up but as of this commit 1f9d0935a1795114c5aea6dde081c72a6fa0d516 they were removed.

so yup you are right, we will have to set it all up again if we wish to use TS.

Mvrs commented 3 years ago

Interesting... I wonder why the reason to move away from TypeScript before.

flybayer commented 3 years ago

@JuanM04 why did you remove tsconfig awhile back?

JuanM04 commented 3 years ago

@flybayer because it wasn't being used. I changed it for a jsconfig knowing that we could recover it with Git