Closed svobik7 closed 3 years ago
After additional circular imports check by running madge . --extensions ts,tsx -c
in root folder I found there are 6 circual dependency warnings.
Processed 472 files (13.8s) (101 warnings)
✖ Found 6 circular dependencies!
1) packages/core/dist/packages/core/src/middleware.d.ts > packages/core/dist/packages/core/src/types.d.ts
2) packages/core/src/middleware.ts > packages/core/src/types.ts
3) packages/core/src/supertokens.ts > packages/core/src/public-data-store.ts
4) packages/file-pipeline/src/transform.ts > packages/file-pipeline/src/types.ts > packages/file-pipeline/src/helpers/file-cache.ts
5) packages/file-pipeline/src/types.ts > packages/file-pipeline/src/helpers/file-cache.ts > packages/file-pipeline/src/utils.ts
6) packages/installer/src/recipe-executor.tsx > packages/installer/src/recipe-renderer.tsx
Hello! Can I try to tackle this issue for the Hacktoberfest2020? If so, can you assign it to me?
@alexnaiman sure, go for it 👍
What is the problem?
During build process of current canary following warning occurred in terminal output:
@blitzjs/core: Circular dependency: src/supertokens.ts -> src/public-data-store.ts -> src/supertokens.ts
Steps to Reproduce
cd blitz
yarn
to install depsyarn build
Versions