search

blitz-research / monkey2

zlib License
131 stars 44 forks source link

Module Manager error? #458

Open DruggedBunny opened 5 years ago

DruggedBunny commented 5 years ago

I just clicked to install png2polygon from Ted2Go's Module Manager, and it appears to be rebuilding all modules, including SDL2, assimp, stb-vorbis, std, etc!

Guessing that's not meant to happen, certainly never done that before!

image

XANOZOID commented 5 years ago

I have also noticed this and thought it may have been a bug . . . I wonder if this is an IDE or tool related thing.

engor commented 5 years ago

IDE update modules, don't rebuild from scratch. I think proper way is to update only modules from depends section.

blitz-research commented 5 years ago

Yes, after a module manager update, monkey2 just does an 'update modules', and the first time this is done all modules end up getting built.

I think proper way is to update only modules from depends section.

Actually, I think just updating the installed/updated modules might be enough as this should automatically update dependancies?

On Fri, Jan 18, 2019 at 5:11 PM Evgeniy Goroshkin notifications@github.com wrote:

IDE update modules, don't rebuild from scratch. I think proper way is to update only modules from depends section.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/458#issuecomment-455421676, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU3Qno3n6PXBbNPBEZq2uxpbolo92iuks5vEUlugaJpZM4aGeWs .

DruggedBunny commented 5 years ago

Is that new? I know in the past (quite some time ago, admittedly) it didn't seem to do this. I actually thought it might be weirdly related to the rebuildall*.bat changes recently, eg. running updateall in error.

I didn't want to cancel the build, not knowing what state things would have been left in, and basically had to find something else to do for half an hour or so! (#firstworldproblems)

It's hard to see the need to rebuild std-vorbis or assimp when adding png2polygon, for instance...

engor commented 5 years ago

Actually, I think just updating the installed/updated modules might be enough as this should automatically update dependancies?

OK.

I didn't want to cancel the build, not knowing what state things would have been left in, and basically had to find something else to do for half an hour or so! (#firstworldproblems)

Yes, if you use precompiled version (and many of users use that) then first update is the same as total rebuild coz there is no built files yet.

engor commented 5 years ago

I just pushed fix into ted2go's dev-branch, since now it will update only performed modules.

seyhajin commented 5 years ago

Can be closed?