Closed StrangeIsMyName closed 8 years ago
small addition of missing color. put it directly after VicRoyal: `
#end
Const VicBlue := New Color( .15,.49,.66 )
`
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
Hi Mark, Partial thanks I think you're wrong not using the full set, they cover all the colors and I am still going to have users whith missing color errors. The next step was finding some way of you using the color selector, but again this is now broken.
I'm not trying to work against you here, I'm really trying to work with you on this.
Jean-Luc
On 30 Sep 2016, at 21:32, Mark Sibly notifications@github.com wrote:
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250845322, or mute the thread https://github.com/notifications/unsubscribe-auth/ATjKVNiJENGBen7jGB7QJGC4ztS1JI00ks5qvXHXgaJpZM4KKTCb.
I am still going to have users whith missing color errors
Umm, why? Why not just include your colors with your code? They're just a bunch of consts, they don't have to be in 'Color' (although with class extensions, you can make it appear as if they are). I really don't understand this and feel like you're making a big deal out of something pretty minor.
The bottom line is I don't want 100001 'custom' colors in std.color.Color, just a simple set of useful stock colors. And I definitely don't want to be adding more colors each time someone needs them for their project!
I don't even think your approach is all that sound for what you're doing - why not stick the colors in a JSON file or something and load them at runtime? Much for flexible, as nothing's hardcoded in so you can have as many palettes/colors as you want, people can add/edit/save palletes etc. And likely easier to code - what have you got in there anyway, a huge array of "name/color" structs? Or a massive sequence of 'AddColorGadget(...)' statements?!? Without reflection, it must be something pretty gnarly!
On Sat, Oct 1, 2016 at 6:37 PM, StrangeIsMyName notifications@github.com wrote:
Hi Mark, Partial thanks I think you're wrong not using the full set, they cover all the colors and I am still going to have users whith missing color errors. The next step was finding some way of you using the color selector, but again this is now broken.
I'm not trying to work against you here, I'm really trying to work with you on this.
Jean-Luc
On 30 Sep 2016, at 21:32, Mark Sibly notifications@github.com wrote:
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84#issuecomment-250845322>, or mute the thread https://github.com/notifications/unsubscribe-auth/ ATjKVNiJENGBen7jGB7QJGC4ztS1JI00ks5qvXHXgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250893996, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU3Quuci_T0ofTw97cGUJv9-KiQFTXVks5qvfGrgaJpZM4KKTCb .
ok, quiet time for 10...
You are (of course) right with the 'your code' 'your colors' and they don't' have to be in color'. it was just that seemed the best place for them to be consistent with the code and be more helpful to users.
You are also right in talking about extensions. But these are an additions which was not there at the time, were not signposted as was coming, etc. So far (in this respect) Monkey2 is a moving target. You start coding and on a whim everything changes...
I'm not going to comment on the last paragraph - I think that's best ;)
OK. It seems that for whatever reason you think I'm working against you? I'm not.
All I wanted was to have a more productive editor for monkey that all users could benefit from.
I can't see what is so wrong with having a pop-up panel that has all the available colors shown in one simple way with color variations
Do you want me to continue and submit the other stuff like the parsing code for mx2cc and the opengl additions for canvas?
Jean-Luc
nOn 1 Oct 2016, at 07:31, Mark Sibly notifications@github.com wrote:
I am still going to have users whith missing color errors
Umm, why? Why not just include your colors with your code? They're just a bunch of consts, they don't have to be in 'Color' (although with class extensions, you can make it appear as if they are). I really don't understand this and feel like you're making a big deal out of something pretty minor.
The bottom line is I don't want 100001 'custom' colors in std.color.Color, just a simple set of useful stock colors. And I definitely don't want to be adding more colors each time someone needs them for their project!
I don't even think your approach is all that sound for what you're doing - why not stick the colors in a JSON file or something and load them at runtime? Much for flexible, as nothing's hardcoded in so you can have as many palettes/colors as you want, people can add/edit/save palletes etc. And likely easier to code - what have you got in there anyway, a huge array of "name/color" structs? Or a massive sequence of 'AddColorGadget(...)' statements?!? Without reflection, it must be something pretty gnarly!
On Sat, Oct 1, 2016 at 6:37 PM, StrangeIsMyName notifications@github.com wrote:
Hi Mark, Partial thanks I think you're wrong not using the full set, they cover all the colors and I am still going to have users whith missing color errors. The next step was finding some way of you using the color selector, but again this is now broken.
I'm not trying to work against you here, I'm really trying to work with you on this.
Jean-Luc
On 30 Sep 2016, at 21:32, Mark Sibly notifications@github.com wrote:
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84#issuecomment-250845322>, or mute the thread https://github.com/notifications/unsubscribe-auth/ ATjKVNiJENGBen7jGB7QJGC4ztS1JI00ks5qvXHXgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250893996, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU3Quuci_T0ofTw97cGUJv9-KiQFTXVks5qvfGrgaJpZM4KKTCb .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250895864, or mute the thread https://github.com/notifications/unsubscribe-auth/ATjKVI2-RT7YOFyXzJG1CTbe_cYPjY9bks5qvf5LgaJpZM4KKTCb.
No, I don't think you're working against me, I just think the idea of adding a bunch of color consts to the standard library for the sake of one app is, well, not a good one.
Feel free to post more issues or submit changes etc, but to be honest unless it's something super simple that looks like it'll be zero hassle to integrate/maintain, there's little chance it''ll be added as I've just got too much other stuff to do.
On Sat, Oct 1, 2016 at 7:57 PM, StrangeIsMyName notifications@github.com wrote:
ok, quiet time for 10...
You are (of course) right with the 'your code' 'your colors' and they don't' have to be in color'. it was just that seemed the best place for them to be consistent with the code and be more helpful to users.
You are also right in talking about extensions. But these are an additions which was not there at the time, were not signposted as was coming, etc. So far (in this respect) Monkey2 is a moving target. You start coding and on a whim everything changes...
I'm not going to comment on the last paragraph - I think that's best ;)
OK. It seems that for whatever reason you think I'm working against you? I'm not.
All I wanted was to have a more productive editor for monkey that all users could benefit from.
I can't see what is so wrong with having a pop-up panel that has all the available colors shown in one simple way with color variations
Do you want me to continue and submit the other stuff like the parsing code for mx2cc and the opengl additions for canvas?
Jean-Luc
nOn 1 Oct 2016, at 07:31, Mark Sibly notifications@github.com wrote:
I am still going to have users whith missing color errors
Umm, why? Why not just include your colors with your code? They're just a bunch of consts, they don't have to be in 'Color' (although with class extensions, you can make it appear as if they are). I really don't understand this and feel like you're making a big deal out of something pretty minor.
The bottom line is I don't want 100001 'custom' colors in std.color.Color, just a simple set of useful stock colors. And I definitely don't want to be adding more colors each time someone needs them for their project!
I don't even think your approach is all that sound for what you're doing
why not stick the colors in a JSON file or something and load them at runtime? Much for flexible, as nothing's hardcoded in so you can have as many palettes/colors as you want, people can add/edit/save palletes etc. And likely easier to code - what have you got in there anyway, a huge array of "name/color" structs? Or a massive sequence of 'AddColorGadget(...)' statements?!? Without reflection, it must be something pretty gnarly!
On Sat, Oct 1, 2016 at 6:37 PM, StrangeIsMyName < notifications@github.com> wrote:
Hi Mark, Partial thanks I think you're wrong not using the full set, they cover all the colors and I am still going to have users whith missing color errors. The next step was finding some way of you using the color selector, but again this is now broken.
I'm not trying to work against you here, I'm really trying to work with you on this.
Jean-Luc
On 30 Sep 2016, at 21:32, Mark Sibly notifications@github.com wrote:
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84# issuecomment-250845322>, or mute the thread https://github.com/notifications/unsubscribe-auth/ ATjKVNiJENGBen7jGB7QJGC4ztS1JI00ks5qvXHXgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84# issuecomment-250893996, or mute the thread https://github.com/notifications/unsubscribe- auth/ADU3Quuci_T0ofTw97cGUJv9-KiQFTXVks5qvfGrgaJpZM4KKTCb .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84#issuecomment-250895864>, or mute the thread https://github.com/notifications/unsubscribe- auth/ATjKVI2-RT7YOFyXzJG1CTbe_cYPjY9bks5qvf5LgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250896851, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU3QiaLx6CjADLVhHFwK9U0V1n7Hbjiks5qvgRhgaJpZM4KKTCb .
mmm
I would totally agree about the "one app". Except the one app is an editor for monkey2: Ted21. which was forked from ted2.
In this case it is not a standard 'app'. It's meant as a replacement/augment to ted2. So there are lots of things added to make any devs life just abit more pleasant. Having a standard set of colors being one of them. You mentioned user palettes - already done and fully integrated (visually) into ted21. custom color mixing done and integrated. Icons strips from bitmap done and integrated into ted21. code overview with custom locations done.
This is not an "app" it should be something that everyone can rely on if they want.
I am now working on the prototype vector editor (just doing final debugging), which will allow for complete libriaries of vector objects, which will make stuff like asteriods a very simple process of just drawing the shapes not trying to work out what the numbers are, etc.
As part of that the next step will be the sprite editor. Which directly integrates into the full color systems already developed.
Ted21 can be considered the visual companion to ted2. If you want to use photoshop and ted2 then that's great. but if you just want to draw a sprite and get it working without anything else, then ted21 is where you go...
I'm trying not to add anything to the modules if possible, but something like the colors, parsing and some core graphic stuff really needs to be in the core itself. As said before the colors (bar any minor corrections) are complete and will not be added to.
On 1 Oct 2016, at 10:18, Mark Sibly notifications@github.com wrote:
No, I don't think you're working against me, I just think the idea of adding a bunch of color consts to the standard library for the sake of one app is a really bad one.
Feel free to post more issues or submit changes etc, but to be honest unless it's something super simple that looks like it'll be zero hassle to integrate/maintain, there's little chance it''ll be added as I've just got too much other stuff to do.
On Sat, Oct 1, 2016 at 7:57 PM, StrangeIsMyName notifications@github.com wrote:
ok, quiet time for 10...
You are (of course) right with the 'your code' 'your colors' and they don't' have to be in color'. it was just that seemed the best place for them to be consistent with the code and be more helpful to users.
You are also right in talking about extensions. But these are an additions which was not there at the time, were not signposted as was coming, etc. So far (in this respect) Monkey2 is a moving target. You start coding and on a whim everything changes...
I'm not going to comment on the last paragraph - I think that's best ;)
OK. It seems that for whatever reason you think I'm working against you? I'm not.
All I wanted was to have a more productive editor for monkey that all users could benefit from.
I can't see what is so wrong with having a pop-up panel that has all the available colors shown in one simple way with color variations
Do you want me to continue and submit the other stuff like the parsing code for mx2cc and the opengl additions for canvas?
Jean-Luc
nOn 1 Oct 2016, at 07:31, Mark Sibly notifications@github.com wrote:
I am still going to have users whith missing color errors
Umm, why? Why not just include your colors with your code? They're just a bunch of consts, they don't have to be in 'Color' (although with class extensions, you can make it appear as if they are). I really don't understand this and feel like you're making a big deal out of something pretty minor.
The bottom line is I don't want 100001 'custom' colors in std.color.Color, just a simple set of useful stock colors. And I definitely don't want to be adding more colors each time someone needs them for their project!
I don't even think your approach is all that sound for what you're doing
why not stick the colors in a JSON file or something and load them at runtime? Much for flexible, as nothing's hardcoded in so you can have as many palettes/colors as you want, people can add/edit/save palletes etc. And likely easier to code - what have you got in there anyway, a huge array of "name/color" structs? Or a massive sequence of 'AddColorGadget(...)' statements?!? Without reflection, it must be something pretty gnarly!
On Sat, Oct 1, 2016 at 6:37 PM, StrangeIsMyName < notifications@github.com> wrote:
Hi Mark, Partial thanks I think you're wrong not using the full set, they cover all the colors and I am still going to have users whith missing color errors. The next step was finding some way of you using the color selector, but again this is now broken.
I'm not trying to work against you here, I'm really trying to work with you on this.
Jean-Luc
On 30 Sep 2016, at 21:32, Mark Sibly notifications@github.com wrote:
Ok, I've added the first set - thanks! - but not the UI, Pico, Ex etc ones as I think these are more suitable for extension modules.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84# issuecomment-250845322>, or mute the thread https://github.com/notifications/unsubscribe-auth/ ATjKVNiJENGBen7jGB7QJGC4ztS1JI00ks5qvXHXgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84# issuecomment-250893996, or mute the thread https://github.com/notifications/unsubscribe- auth/ADU3Quuci_T0ofTw97cGUJv9-KiQFTXVks5qvfGrgaJpZM4KKTCb .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/blitz-research/monkey2/issues/84#issuecomment-250895864>, or mute the thread https://github.com/notifications/unsubscribe- auth/ATjKVI2-RT7YOFyXzJG1CTbe_cYPjY9bks5qvf5LgaJpZM4KKTCb.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250896851, or mute the thread https://github.com/notifications/unsubscribe-auth/ADU3QiaLx6CjADLVhHFwK9U0V1n7Hbjiks5qvgRhgaJpZM4KKTCb .
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blitz-research/monkey2/issues/84#issuecomment-250902409, or mute the thread https://github.com/notifications/unsubscribe-auth/ATjKVE-zkoiNSvtFcCyrAUZWRPoyaYmRks5qviVNgaJpZM4KKTCb.
Hi Mark, Here are the color additions for std/graphics/color basically added some new base colors and 5 separate color groups: UI which has a lot of the microsoft UI colors Pico which has the pico-8 colors Xam which has the popular xamarin colors Vic which has the commodore base colors and Ex which are the extended colors. Note the new order for the base colors which groups them in proper color pattern
These are the total final colours I added to support Ted21. No more will be added or removed.
There is also a small function addition to allow integer color definitions
`'new jl added function
rem monkeydoc Allows a colors to be defined using integer values 0..255 instead of 0..1
end
Function ColorI:Color( red:Float, green:Float, blue:Float, alpha:float = 255 ) Return New Color( red / 255, green / 255, blue / 255, alpha / 255) End`
`#- 'begin of jl added colors. 'NOTE. The colors have also been merged into the original colors and now flow correctly together. 'E.G. blacks to whites, reds to brown to green to blue. so it's best to keep them like this
rem monkeydoc ExBuff.
'end of JL added colors
-