search

blitzarx1 / egui_graphs

Interactive graph visualization widget for rust powered by egui and petgraph
https://docs.rs/crate/egui_graphs
MIT License
388 stars 29 forks source link

[egui::Windows compatibility] Graph rendering stay on top of all egui::Windows #179

Closed deft01 closed 7 months ago

deft01 commented 7 months ago

Hi,

Thanks a lot for the quick bug fix that makes compatibility with egui::Windows available.

I have discovered a new bug.

Graph rendering stay on top of all the egui::Windows even if the Window where the graph is not focused. I tested different configuration of GraphView, always with the same behavior.

image

My versions (using last commit version on master) :

egui = "0.26.0"
egui_extras = { version = "0.26.0", features = ["svg", "image"]}
eframe = { version = "0.26.0", default-features = false, features = [
    "accesskit",     # Make egui comptaible with screen readers. NOTE: adds a lot of dependencies.
    "default_fonts", # Embed the default egui fonts.
    "glow",          # Use the glow rendering backend. Alternative: "wgpu".
    "persistence",   # Enable restoring app state when restarting the app.
] }
egui_tracing = "0.2.1"

serde = { version = "1", features = ["derive"] }
serde_json = { version = "1.0", features = ["raw_value"]}
ron = "0.8"
egui_graphs = { git = "https://github.com/blitzarx1/egui_graphs", branch = "master", features = ["egui_persistence", "serde"]}
blitzarx1 commented 7 months ago

Thanks for the report! I know the reason, I will try to fix it today.

blitzarx1 commented 7 months ago

I refused from using egui layer ordering mechanism for ordering graph drawing, because it conflicts with other egui components, which is demonstrated by this bug.

I returned to simple time ordering and I will keep it this way for now.

blitzarx1 commented 7 months ago

fix is in the master

oisyn commented 7 months ago

EDIT: Yeah I'm just going to remove my comment. #180 fixes everything for us as well 😄