blitzmann / Pyfa

Python fitting assistant, cross-platform fitting tool for EVE Online
GNU General Public License v3.0
3 stars 0 forks source link

Fit tagging thoughts #15

Open blitzmann opened 10 years ago

blitzmann commented 10 years ago

It's been a long requested feature to have tagging support for different fits, with each fit having a variety of tags. This can more clearly label ship doctrines, etc. However, there's the problem of how to present this information, along with how to go about doing it on the backend.

  1. How to present the different tags. I've thought of two ways: adding a Tags tab to the browser (with Market and Ships), or adding a toggle icon to the existing Ships browser. I think the toggle icon would be easier to implement and look nicer, as I envision showing tags the same way showing the main ship browser.
  2. How to show the different tags attributed to the ship. This is a bit harder, as there is no place where general information is available for this fit itself. One idea is to have a new Additions page, which simply lists a comma-separated list of current tags, removed by double click. That's probably the easiest way. To add tags, a context item Add tag may be included for the fit in the browser which pops up a dropdown list.

Overall, that seems a bit too... convoluted. Tags here, tags there. A much better solution would be to have a new stage, or "Page", for the ship browser showing general fit information, including traits of current chip, possible user-defined description, and list of tags, among other little trinkets. This, I think, is much more work, but more more visually apealing

blitzmann commented 10 years ago

Started work on this

Added new 'stage' to the ship browser. currently, when you select a fit, it goes to this new stage. Stage is filled with dummy info for now. This is probably not the final behavior - many folks probably don't want to see this new stage unless they explicitly say so. So it's my intention to make it show after fit only if noted in settings (default = no). Otherwise, there will be a show info icon in the ship browser navigation that, when clicked, will open this new 'Description' stage for the active fit.

As for what's included in description:

blitzmann commented 10 years ago

Added getTagList to EOS queries, and called directly from ship browser. The way it's done regularily is calling it from a service, but I didn't want to make a new service for such a simple thing, and I didn't think it would 'fit' in with the fit service.

blitzmann commented 10 years ago

Instead of integrating it into shipbrowser, decided to make a TagBrowser which is basically a stripped.down.version of shipBrowser. This allows for easy navigation and not having to worry about the shipBrowser navigation history. When selecting a tag, it will display all fits with that tag. In the navigation, it will have a butoonto export all fits in a tag.

blitzmann commented 10 years ago

Also added show info icon to fitting veiw tab container. I thought about adding it to the ship browser navigation and alogning it to the right, but.the current custom toolbar that pyfa uses would need to be havily modified to allow for that. And the navigation would be cluttered. I also thought about replacing the shiprace icon in the tab with show info icon with bility to know when user click.on.the icon. Again, that was too much work and potential for.breakage. decided to just add icon to the tab container.

blitzmann commented 10 years ago

Idea: drag tag to fit to apply