search

blitzpp / blitz

Blitz++ Multi-Dimensional Array Library for C++
https://github.com/blitzpp/blitz/wiki
Other
405 stars 84 forks source link

Removal of many namespace related macros. #136

Closed papadop closed 5 years ago

papadop commented 5 years ago

This is a huge commit but it's mainly grep and perl substitutions. This commit removes the use of BZ_NAMESPACE, BZ_NAMESPACE_END, BZ_BLITZ_SCOPE, BZ_STD_SCOPE, BZ_USING_NAMESPACE macros (I hope I have not forgotten any). There are a few similar macros remaining but I guess the patch is already big enough.

This is a first step towards removing cxx features macros and it removes already one. Probably, a few other are not too difficult as a followup (namespace for std and math functions).

It compiles with both autotools and cmake on linux. Let's see what travis/appveyor says....

slayoo commented 5 years ago

Thank you! Seems OK to me. @citibeth @lutorm ?

citibeth commented 5 years ago

It compiles with both autotools and cmake on linux.

@slayoo I would like to see if we can get an official release out shortly. Once that release is out, then we go forward with "breaking" changes, for example:

I think this PR should be merged soon because it will become "stale" and unmergable fast.