search

blitzpp / blitz

Blitz++ Multi-Dimensional Array Library for C++
https://github.com/blitzpp/blitz/wiki
Other
402 stars 83 forks source link

Windows Build #153

Closed David-A-Blankenship closed 4 years ago

David-A-Blankenship commented 4 years ago

I use blitz on Windows and have updated the CMake files, and one header file, to handle the build on Windows including boost serialization. I would like permission to push my branch and create a pull request to get these changes in the repository. I am actively working with blitz and may be able to contribute additional changes in the future, such as cleaning up some of the compiler warnings generated on Windows and maybe help with CMake.

Changes: blitz/blitz.h - to add __declspec for #ifdef WIN32 cmake/BlitzConfigFileName.cmake - to change EQUAL to STREQUAL cmake/Win32Compat.cmake - to change the CMAKE_RUNTIME_OUTPUT_DIRECTORY to CMAKE_BINARY_DIR/src src/CMakeLists.txt - to add find_package for Boost serialization if ENABLE_SERIALISATION

Tested: Windows

CentOS

I did not see any other way to contact someone about permissions to push.

Thanks.

David

David-A-Blankenship commented 4 years ago

Here are the cmake command lines that I used to create the projects.

Windows: cmake.exe" -DENABLE_SERIALISATION=1 -G"Visual Studio 16 2019" -A x64 -DCMAKE_INSTALL_PREFIX="c:/dev/blitz" ..

CentOS: cmake -DENABLE_SERIALISATION=1 -DCMAKE_INSTALL_PREFIX="/home/dblanken/blitz" -DCMAKE_BUILD_TYPE=Debug ..

papadop commented 4 years ago

I do not think I can grant you the rights you ask. But I can make a suggestion. Why don't you clone the git repo, create the branch on your clone and ask for a PR from there (you can ask a PR to the original repo) ??? That should always work...

David-A-Blankenship commented 4 years ago

Thank you. I will give that a try.

On Wed, Dec 4, 2019 at 10:55 AM Theodore Papadopoulo < notifications@github.com> wrote:

I do not think I can grant you the rights you ask. But I can make a suggestion. Why don't you clone the git repo, create the branch on your clone and ask for a PR from there (you can ask a PR to the original repo) ??? That should always work...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/blitzpp/blitz/issues/153?email_source=notifications&email_token=AN6PV2FZMKPCQBH2UHX66ZTQW7OILA5CNFSM4JVLTI52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5WIOY#issuecomment-561734715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN6PV2GKYITTKB4UEY5MBXLQW7OILANCNFSM4JVLTI5Q .

slayoo commented 4 years ago

closing as we have the PR now #154 Thank you!