search

blitzpp / blitz

Blitz++ Multi-Dimensional Array Library for C++
https://github.com/blitzpp/blitz/wiki
Other
405 stars 84 forks source link

patch to fix out-of-source build problem #82

Closed slayoo closed 5 years ago

slayoo commented 5 years ago

Patch proposed by Seth Johnson (@sethrj?) migrated from SF: https://sourceforge.net/p/blitz/patches/12/

Out-of-source builds failed (when doing "make lib install") because the dependencies on the executables created in "blitz/generate" use a relative path. The attached patch substitutes the top source dir with the top build dir.

Index: blitz/generate/Makefile.am
===================================================================
RCS file: /cvsroot/blitz/blitz/blitz/generate/Makefile.am,v
retrieving revision 1.17
diff -r1.17 Makefile.am
47c47
<   ./$(patsubst %.cpp,%$(EXEEXT),$<)
---
>   $(patsubst %.cpp,%$(EXEEXT),$(subst $(top_srcdir),$(top_builddir),$<))
50c50
<   ./$(patsubst %.cpp,%$(EXEEXT),$<)
---
>   $(patsubst %.cpp,%$(EXEEXT),$(subst $(top_srcdir),$(top_builddir),$<))
sethrj commented 5 years ago

Hah! Yes, that was indeed me, ages ago :)

citibeth commented 5 years ago

@slayoo this looks reasonable enough, can it be merged safely?

slayoo commented 5 years ago

PR created: https://github.com/blitzpp/blitz/pull/100