blitzpp / blitz

Blitz++ Multi-Dimensional Array Library for C++
https://github.com/blitzpp/blitz/wiki
Other
404 stars 83 forks source link

pkgconfig reports version 0.10 #91

Closed bryanburgers closed 5 years ago

bryanburgers commented 5 years ago

When installing 1.0.1, pkg-config reports the version as 0.10 instead of 1.0.1.

$ docker run -it --rm centos:6 /bin/bash
[root@e8aa770a4863 /]# yum install -q -y gcc-c++
warning: rpmts_HdrFromFdno: Header V3 RSA/SHA1 Signature, key ID c105b9de: NOKEY
Importing GPG key 0xC105B9DE:
 Userid : CentOS-6 Key (CentOS 6 Official Signing Key) <centos-6-key@centos.org>
 Package: centos-release-6-10.el6.centos.12.3.x86_64 (@CentOS/6.10)
 From   : /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-6
[root@e8aa770a4863 /]# curl -s -L -o blitz-1.0.1.tar.gz https://github.com/blitzpp/blitz/archive/1.0.1.tar.gz
[root@e8aa770a4863 /]# tar -xzf blitz-1.0.1.tar.gz
[root@e8aa770a4863 /]# cd blitz-1.0.1
[root@e8aa770a4863 blitz-1.0.1]# mkdir /opt/blitz
[root@e8aa770a4863 blitz-1.0.1]# ./configure --prefix /opt/blitz >/dev/null 2>&1
[root@e8aa770a4863 blitz-1.0.1]# make >/dev/null
[root@e8aa770a4863 blitz-1.0.1]# make install >/dev/null
[root@e8aa770a4863 blitz-1.0.1]# PKG_CONFIG_PATH=/opt/blitz/lib/pkgconfig pkg-config --modversion blitz
0.10
[root@e8aa770a4863 blitz-1.0.1]# cat /opt/blitz/lib/pkgconfig/blitz.pc | grep Version
Version: 0.10
[root@e8aa770a4863 blitz-1.0.1]#
citibeth commented 5 years ago

So there's probably something somewhere in the Blitz++ build that has 0.10 hardcoded in it. Can someone grep for that and find the string we need to change?

slayoo commented 5 years ago

Related: https://github.com/blitzpp/blitz/pull/25/files (merged hence closing this one) BTW1, another one will be needed to be maintained when CMake build will be merged BTW2, here's a draft of a "Release checkilist" wiki entry that includes mention of bumping the version number in configire.ac: https://github.com/blitzpp/blitz/wiki/Release-checklist