search

blmage / mage-enhanced-admin-grids

[ARCHIVED] Enhanced Admin Grids extension for Magento 1. WIP version available for testing.
248 stars 115 forks source link

Filtering is broken in a grid inside of a tab #62

Closed kalenjordan closed 10 years ago

kalenjordan commented 11 years ago

I've noticed that filtering is broken within my custom grid (using ajax) inside of a tab. I see the record for the grid in customgrid_grid.

I haven't customized the grid at all, but it seems that this module creates a record for every grid that you access, whether or not you customize it.

It was a little bit hard to debug because as I was attempting to step through the code, it wasn't able to step into Mage_Adminhtml_Block_Widget_Grid::_setFilterValues(). Not really sure how the dynamic block rewrites work...?

mage-eag commented 11 years ago

Currently the grid rewrites work with eval(), but a new rewriting system is under work, that should allow to choose between eval() or automatic class files generation, so once available it should be possible to step through the rewrite code with this second solution.

Anyway, does this only happen with your custom grid (regarding grid inside of tabs) ? Do you know how to reproduce the problem / can you share your custom code ?

mage-eag commented 10 years ago

Do you still encounter filtering problems in your custom grid ? If so, can you debug it with the file rewriter enabled and prioritized ? Thanks :)

kalenjordan commented 10 years ago

Hey! Just tested this on a grid inside of a tab and it worked.

I can't remember the initial test case that was breaking for me, but I think we're all good here now. Thanks!!