bloc97 / Anime4K

A High-Quality Real Time Upscaler for Anime Video
https://bloc97.github.io/Anime4K/
MIT License
18.23k stars 1.34k forks source link

I hope can see the HLSL ver update #112

Open tkp206093 opened 3 years ago

tkp206093 commented 3 years ago

Is your feature request related to a problem? Please describe. I hope can see the HLSL ver update

Describe the solution you'd like Because I very love use PotPlayer but PotPlayer not support GLSL ver

Describe alternatives you've considered PotPlayer only can use HLSL (v0.9 Beta)

Additional context HLSL ver update PLS!

softbearlolz commented 3 years ago

I hope this too

TianZerL commented 3 years ago

See #47

Jules-A commented 3 years ago

Yeah this is a dupe but I never got an answer on the other issue on whether the non-CNN shaders could be converted to HLSL.

TianZerL commented 3 years ago

@Jules-A There is only one temporary texture can be used in HLSL of DirectShow based player, so it's not just CNN shaders that's hard to rewrite.

Jules-A commented 3 years ago

@Jules-A There is only one temporary texture can be used in HLSL of DirectShow based player, so it's not just CNN shaders that's hard to rewrite.

Even for Dark/Thin Lines shaders? They are the ones I'm most interested combining with MadVR.

bloc97 commented 3 years ago

Line thining already exists in MadVR, though it seems the implementation might be different. For line darkening it should be possible as it only needs 1 additional channel for storing data.

Jules-A commented 3 years ago

Line thining already exists in MadVR, though it seems the implementation might be different. For line darkening it should be possible as it only needs 1 additional channel for storing data.

But it's not very good and doesn't allow fine tuning. For example, I run Anime4k's line thinning at 0.36 strength and 2 iterations, it's very different from the default settings although it does have it's strengths (720p+) and weakness (480p- or aliased).

Durden-T commented 3 years ago

me too