bloc97 / Anime4K

A High-Quality Real Time Upscaler for Anime Video
https://bloc97.github.io/Anime4K/
MIT License
18.53k stars 1.35k forks source link

Upscale filter no longer working - unsure why #232

Closed roseyhead closed 9 months ago

roseyhead commented 9 months ago

Describe the bug A few weeks back I set up Anime4K HQ on an existing Plex HTPC install. Worked great at the time but at some point I noticed the upscale filter had stopped working, as in no visual difference in sharpness between A/B/C/Off. There were some changes in contrast with the filters on and off due to Anime4K_Clamp_Highlights.glsl so I can verify that Anime4K in general works. For example I played around with input.conf and created a couple of custom profiles with a mix of filters - if I create a new profile the same as A but without Anime4K_Clamp_Highlights.glsl there is zero visual difference with that turned on or off. Also tried completely reinstalling Plex HTPC and removing the localappdata folder but made no difference.

To Reproduce Steps to reproduce the behavior:

  1. Download GLSL_Windows_High-end.zip and extract to %localappdata%/Plex HTPC
  2. Open Plex, open a video
  3. Toggle between A/B/C/off
  4. Anime4K_Clamp_Highlights.glsl works but Anime4K_Upscale_CNN_x2_VL.glsl makes no visible difference

Expected behavior Fileter combination should sharpen lines

Screenshots I'm logging this while at work so I don't have any screenshots (not sure they should be necessary) but can provide if required

Desktop (please complete the following information):

Additional context I'm not sure what might have changed, except for migrating my Plex server install from an Ubuntu PC to Docker on a Debian PC but that shouldn't make a difference, right?

Tama47 commented 9 months ago

Can you verify by checking the profiler if Anime4K is running?

Add this line to your input.conf inside %LOCALAPPDATA%\Plex HTPC (if you haven't already).

i script-binding stats/display-stats-toggle

Quit and reopen Plex HTPC. Then press i and 3 while playing video. It should show all the shaders being rendered.

Also, keep in mind that Anime4K_Upscale_CNN shaders only upscale the resolution, i.e., from 1080p to 2160p. The shaders responsible for sharpening lines are the Anime4K_Restore_CNN shaders.

roseyhead commented 9 months ago

Hey! Thanks for the response. I've turned that on and grabbed a couple of screenshots. Here's a screenshot with the default A filters enabled: a default filter

And one with them disabled: filters off Magenta's a very slightly different shade of magenta in each but aside from that it looks identical to my eyes.

For comparison's sake, here's a shot with only Anime4K_Clamp_Highlights.glsl enabled: just clamp highlights

And a shot with only Anime4K_Restore_CNN_VL.glsl x3 (i'd expect this to oversharpen massively? or at least have some effect) just restore 3x

The only difference I can see is a slight change in contrast in parts of the image when the clamp filter is on. Also, just to clarify, this is all 1080p video played on a 2160p screen. Like I said it definitely worked the first time I set it up, so I know how it's meant to look!

Tama47 commented 9 months ago

Lovely screenshots of Magenta!

Anyway, it seems like the shaders are active and running normally. I do see that there's not much difference between having the shaders on or off, aside from the slight contrast. I'm running the latest version of Plex and Plex HTPC on both Mac and Windows systems, and Anime4K still works fine. So, I highly doubt this is an issue with the Plex app itself.

Just to isolate the issue, could you try running the shaders in mpv or the normal Plex app and see if Anime4K is working correctly there? Also, try downloading the shaders again directly from Releases, as there could be something wrong with the files. You could also try using these combined preset shaders and see if they work.

roseyhead commented 9 months ago

Thanks, in hindsight it was kinda dumb of me not to try Plex Desktop and MPV before creating an issue. The shaders did the same thing on Plex but MPV worked as expected, which caused me to remember that at some point I'd replaced the Plex mpv library via this guide: https://forums.plex.tv/t/htpc-tips-and-tricks/794228/3 Dropped in the latest mpv-2.dll and it's all working great. Looking at my browser history I did this AFTER originally installing Anime4k though, so could be that's what broke it in the first place? At any rate that's fixed it this time so I'm happy. Thanks for your help :)

Tama47 commented 9 months ago

That’s interesting! I didn’t even realize you could replace the mpv library in Plex. Maybe I’ll give it a try, since I do want to use their new library and I’ll see if it breaks Anime4K too. Anyway, glad it worked out for you!

Tama47 commented 9 months ago

So I just replaced the old libmpv in Plex HTPC with the new one, and Anime4K seems to be working for me.

Old libmpv on Mac:

Screenshot 2024-02-11 at 04 30 38

New libmpv on Windows: Anime4k Off

Screenshot 2024-02-11 at 04 33 49

Anime4K On

Screenshot 2024-02-11 at 04 32 43 Screenshot 2024-02-11 at 04 32 54
roseyhead commented 9 months ago

Little FYI - Plex HTPC updated today and I noticed Anime4K broken the same way as it was when I opened this issue - replaced mpv-2.dll the same way which immediately fixed it.

Tama47 commented 9 months ago

Yep, the same thing happened to me. Although, I replaced it with the new libmpv and it works just fine. What concerns me, though, is that I will need to keep replacing the mpv-2.dll file every time there is an update. Which would be pretty annoying as Plex updates pretty often, and I didn't have this issue prior to changing the mpv-2.dll file. But the trade-off might be worth it for the new libmpv alone, considering that Plex still uses the old mpv library.