Add use of coinselect to improve transaction sending

block-core / blockcore-wallet

Web5 Wallet for your coins, tokens, identities, NFTs and more.

https://www.blockcore.net/wallet

MIT License

43 stars 33 forks source link

Add use of coinselect to improve transaction sending #281

Closed sondreb closed 1 year ago

sondreb commented 1 year ago

Add dependency on coinselect.
Hides the input for fee, user doesn't need to think about it.
Makes the fee sat/byte to avoid confusion and value transformations.
Improves the max send option.

dangershony commented 1 year ago

Hides the input for fee, user doesn't need to think about it.

I think this is good user UX but we should not allow also a user to manage that?

sondreb commented 1 year ago

Hides the input for fee, user doesn't need to think about it.

I think this is good user UX but we should not allow also a user to manage that?

I think most apps allow users to configure fee a bit, but mostly hidden. We'll leave it like this for now and change depending on user feedback and needs.