block / goose

Goose is a developer agent that operates from your command line to help you do the boring stuff.
https://block.github.io/goose/
Apache License 2.0
108 stars 17 forks source link

chore: use primitives instead of typing imports and fixes completion … #149

Closed codefromthecrypt closed 1 week ago

codefromthecrypt commented 1 week ago

…signature

This migrates from typing imports to primitives per the following feedback from @lamchau:

:nit: i think our patterns here don't realize as of python 3.9+ we generally don't need Dict, List, and Tuple anymore we can use the primitives (dict, list, and tuple respectively)

This also fixes inconsistency in our provider completion signature with regards to:

-        messages: List[Message],
-        tools: Tuple[Tool],
-    ) -> Tuple[Message, Usage]:
+        messages: list[Message],
+        tools: tuple[Tool, ...],
+        **kwargs: dict[str, any],
+    ) -> tuple[Message, Usage]:
lamchau commented 1 week ago

lgtm!