block / goose

Goose is a developer agent that operates from your command line to help you do the boring stuff.

https://block.github.io/goose/

Apache License 2.0

112 stars 17 forks source link

feat: add execute method to commands #17

Closed lukealvoeiro closed 1 month ago

lukealvoeiro commented 1 month ago

About

Before this PR, commands would lexed in the following way:

/file:)("asf) asdf"

After this PR, commands are lexed as so:

Improves lexing of commands, recognizing command values within quote marks to allow folks to add plenty of spaces
Implements the execute portion of the command
Adds the surrounding context to the command, in case the command needs it.

lifeizhou-ap commented 1 month ago

I am curious whether there is any real use case to use the command execute? If not, Shall we wait to implement this until we have the real requirements? In this case the implementation will fit better for the requirement.

It would be good to have a clear purpose while we adding code as code maintenance could be a cost.

lukealvoeiro commented 1 month ago

@lifeizhou-ap we have the quorum toolkit which will be using this, as well as the file command. given this, that's why the ticket has a high priority on our internal Linear board.

it's also a bit of a catch-22, where if we don't give engineers the ability to run commands, we won't see additional use-cases for it.