Open Kvadratni opened 2 days ago
I think this works well - any idea of impact of these new dependencies to the core of goose? (that would be main concern, vs some way to extend it when needed)
I think this works well - any idea of impact of these new dependencies to the core of goose? (that would be main concern, vs some way to extend it when needed)
These dependencies are rather small and I did not notice any impact to performance. That said I would prefer goose to hace a nice extension system so that we could off and on-load when needed.
on a related note browser "sniffing" can lag, if we're going to write platform detection piece we can greatly simplify macos via duti -x
rather than what we generated here. i feel that's a very dated and not a great approach (note: it does require yet another binary dependency)
edit: if we want to stick with reading the plist we can just do it in python with plistlib
which feels more sensible then the shell stuff we have
yeah I am not worried about platforms for now, if the dependencies are modest I like the idea of this - will try to test it out today.
disabled default browser search in other platforms
This pull request includes a new
BrowserToolkit
for web interactions, and updating the test suite to cover new functionalities.video demo link: https://square.enterprise.slack.com/files/U01TS4JBLN6/F07SPPVQZGE/screen_recording_2024-10-21_at_4.04.38___pm.mov