search

blockbasti / just_another_workout_timer

A simple timer for your workouts, built with Flutter!
MIT License
136 stars 23 forks source link

Unable to display 23 seconds (or any non 10-multiples) in edit window #197

Open romanoce opened 7 months ago

romanoce commented 7 months ago

Is your feature request related to a problem? Please describe.

Before app update, many of my workouts are not multiples of 10 seconds (old version made it very convenient to adjust workout times in steps of 1 second). After updating to 1.13.0, duration of these workouts cannot be displayed in edit window unless I tab on the time.

Describe the solution you'd like

Some possible solutions:

  1. Two independent numeric sliders resulting in a 2-digits workout time.
  2. A circle clock appears after tapping the time, similar to alarm clock in Android.
crimsoncor commented 7 months ago

I don't love the new spinners at all because I keep accidentally hitting them when trying to scroll through sets. Maybe a preferences toggle that would let people revert to the old style?

romanoce commented 7 months ago

I often accidentally hit on the spinners too.

I see the point of new spinners - they allow quick adjustment of long workout times. Perhaps to get the best from both worlds, use the old increment button style plus a numeric box for entering numbers explicitly upon tapping?

crimsoncor commented 7 months ago

I'm thinking maybe a couple things.

Three modes in prefs for entering durations

  1. Current Spinner method
    • Add a pref to set the granularity of the spinner
    • Consider changing editing UX where if an old workout is loaded with a value that falls outside the spinner's allowed values, default it to the old style +/- box? At least that way you can see and edit the value easily.
  2. Old +/- button style
    • Maybe add prefs for small and big step?
  3. Completely manual entry with a text box.
crimsoncor commented 4 months ago

My latest thoughts. Keep the spinners Add an option that lets you change the spinners to tap to activate. That way you can't accidentally spin them while scrolling (if you turn the pref on). (in that mode, it would be long press to do manual entry) Add an option for spinner granularity. Change the UI to show the edit box instead of the spinner when you have a value that doesn't fit into the spinner granularity.