blockchain-IoT / Motoro

Smart contracts for decentralized rentals of vehicles.
https://www.toptal.com/ethereum/motoro-iot-in-transportation
MIT License
107 stars 39 forks source link

Closes #14, closes #15; Create dapp to register new owner, vehicle #23

Closed ghost closed 6 years ago

ghost commented 6 years ago

Closes:

14 Create dapp to register new owner

15 Create dapp to register new vehicle

Changes proposed:

@michalmikolajczyk I'd appreciate your feedback

michalmikolajczyk commented 6 years ago

Basically the work looks really cool!

  1. I would suggest we refer to Airbnb style guide https://github.com/airbnb/javascript for both JS and React. I will add an eslint file.
  2. I am not sure if we should load the full ui-kit package. We don't need the rtl file, and I don't really see us modifying the package – perhaps the minified files would suffice?
  3. we need to have proper unit test coverage of all files with business logic
michalmikolajczyk commented 6 years ago

in fact, can we use ui kit from npm?

michalmikolajczyk commented 6 years ago

I applied another commit, now we use ui kit from npm.