search

blockchain-audit / meridian-starknet

Meridian Protocol on Starknet
0 stars 0 forks source link

create getETH, getLUSDDebt, sendETH functions #146

Open HadasaHazan opened 1 week ago

HadasaHazan commented 1 week ago

in this issue you shouled be creating a branch from the branch Active-Pool and when you are done you shouled create a pr to this branch Active-Pool not to main

https://github.com/blockchain-audit/liquity-contracts/blob/98bb33179685b1e7b41aebef18730c790e81644c/src/ActivePool.sol#L70

https://github.com/blockchain-audit/liquity-contracts/blob/98bb33179685b1e7b41aebef18730c790e81644c/src/ActivePool.sol#L74

https://github.com/blockchain-audit/liquity-contracts/blob/98bb33179685b1e7b41aebef18730c790e81644c/src/ActivePool.sol#L80

HadasaHazan commented 1 week ago

you need to do also this function: sendETH

tova100 commented 1 week ago

chani : you need to do sendSTARK and this function to use of transfer (from erc20) function and transfer to activepool(address -smart contract that get )the amount that get in this function also need to change interface