blockchain-certificates / BlockcertsFramework-iOS

An iOS wallet for viewing, validating, and sharing certs
MIT License
20 stars 15 forks source link

V2 Updates #31

Closed kimdhamilton closed 7 years ago

kimdhamilton commented 7 years ago

Bring up to v2 verification standards, most significantly, adding authenticity checks to verify the issuer address from the transaction checks out with those on the issuer id page. We want to ensure that the tx was issued when the issuing key was valid.

Exceptional cases handled:

Added more test cases to: cert-walletTests/CertificateValidationRequestTests.swift

There is a lot of code duplication in that test class, but I'm having issues getting the test expectations cleanly refactored. I did some cleanup to make this easier in the future.

Opened issue #32 to track detection of unmapped JSON-LD fields. This will be doable; just need to find the right way to pass the fallback context to swift ld libraries during normalization.

Note I changed assertion id (uid) to extract just the guid to allow for the following cases:

kimdhamilton commented 7 years ago

pushed fixes for PR feedback. Confirmed tests pass locally. Waiting for travis build, and will merge if everything looks good