Requested changes for September 2018 release.

blockchain-certificates / BlockcertsFramework-iOS

An iOS wallet for viewing, validating, and sharing certs

MIT License

20 stars 15 forks source link

Requested changes for September 2018 release. #40

Closed mjhshin closed 6 years ago

mjhshin commented 6 years ago

Removed module maps for CommonCrypto since it is now natively exposed to Swift in Xcode 10.
Replacing flatMap which has been deprecated in some use cases for compactMap.
Fix for intercepting successful issuer add URL in WKWebView.

tvalenta commented 6 years ago

I updated xcode to version 10. build clean succeeds, but test fails at /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/include/CommonCrypto/module.modulemap:1:8: error: redefinition of module 'CommonCrypto' module CommonCrypto [system] [extern_c] { ^ Could you take a look?

mjhshin commented 6 years ago

In my PR, I've removed the module maps for CommonCrypto because it's no longer necessary in Xcode 10 and causes the above redefinition failure. Could you please check that the CI build included my changes?