Error when ethereum_rpc_url is None

blockchain-certificates / cert-issuer

Issues Blockcerts using either the Bitcoin or Ethereum blockchain

MIT License

414 stars 208 forks source link

Error when ethereum_rpc_url is None #211

Closed antonellopasella closed 3 years ago

antonellopasella commented 3 years ago

PR for https://github.com/blockchain-certificates/cert-issuer/issues/210

lemoustachiste commented 3 years ago

ok so if I understand correctly this will silently fail now?

lemoustachiste commented 3 years ago

I don't this is a good change, it's obfuscating potential misconfiguration and I would rather see an error to debug and understand that I need to configure something than to silently skip a step that I may need.