blockchain-certificates / cert-issuer

Issues Blockcerts using either the Bitcoin or Ethereum blockchain
MIT License
414 stars 208 forks source link

Missing argument for CertificateV3Handler constructor #286

Closed san-esc closed 3 months ago

san-esc commented 3 months ago

There is a missing argument on line 64 of file /cert_issuer/blockchain_handlers/ethereum/__init__.py that makes issuing with ethereum fails with the following error:

TypeError: CertificateV3Handler.__init__() missing 1 required positional argument: 'app_config'

HarukiKondo commented 3 months ago

I have a same error.

lemoustachiste commented 3 months ago

Hi,

thanks for reporting the issue, do you mind opening a PR fixing the problem? I don't have much cycles to work on that at the moment.

If you do, please follow the angular commit convention to ensure proper semantic release: https://www.conventionalcommits.org/en/v1.0.0/

HarukiKondo commented 3 months ago

https://community.blockcerts.org/t/cert-issuer-c-conf-ini-error/3450/5

HarukiKondo commented 3 months ago

I found solution of this problem!!

lemoustachiste commented 3 months ago

Thanks all for your contribution and support