search

blockchain-etl / blockchain-etl-streaming

Streaming Ethereum and Bitcoin blockchain data to Google Pub/Sub or Postgres in Kubernetes
https://medium.com/google-cloud/live-ethereum-and-bitcoin-data-in-google-bigquery-and-pub-sub-765b71cd57b5
MIT License
77 stars 21 forks source link

Fix sidecar graceful termination #12

Closed voron closed 4 years ago

voron commented 4 years ago

SSIA. It works as expected in my tests with increased terminationGracePeriodSeconds. Download inside container runtime is a bad practice, but I don't expect this container to fail in restart loop.

medvedev1088 commented 4 years ago

Great job!

It works as expected in my tests with increased terminationGracePeriodSeconds.

Did you also have to increase terminationGracePeriodSeconds to make it work? I didn't see it in the PR?

voron commented 4 years ago

Did you also have to increase terminationGracePeriodSeconds to make it work?

Sometimes it needs 30+ seconds to stop correctly, thus I've increased terminationGracePeriodSeconds to 120 just in my tests to have a clear result of proposed changes. But you're right, there is a point to increase terminationGracePeriodSeconds in chart too, I've updated the PR.