Closed voron closed 4 years ago
Great job!
It works as expected in my tests with increased terminationGracePeriodSeconds.
Did you also have to increase terminationGracePeriodSeconds to make it work? I didn't see it in the PR?
Did you also have to increase terminationGracePeriodSeconds to make it work?
Sometimes it needs 30+ seconds to stop correctly, thus I've increased terminationGracePeriodSeconds
to 120 just in my tests to have a clear result of proposed changes. But you're right, there is a point to increase terminationGracePeriodSeconds
in chart too, I've updated the PR.
SSIA. It works as expected in my tests with increased
terminationGracePeriodSeconds
. Download inside container runtime is a bad practice, but I don't expect this container to fail in restart loop.