added copyID feature - Githubissues

blockchainProject / blockchain-project-client

GrabJob is the world’s first job marketplace with Blockchain technology

MIT License

3 stars 2 forks source link

added copyID feature #207

Open naganeo opened 7 years ago

naganeo commented 7 years ago

Review please

taisukemino commented 7 years ago

Thanks! Here is my feedback.

I suggest that you move onclick event and its function to the view
It's better to allow users to copy as many times as possible, I think
you added two clipboard packages in package.json

taisukemino commented 7 years ago

memo from the meeting on May 6, 2017.

copiedText function in the View is not fired due to newly created DOM element when a users hovers on the GUID text. One solution I can think of is to add hover event inside the View and then add click event inside the function called.