116 tabs refactoring - Githubissues

blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain

https://wallet.bitshares.org

MIT License

0 stars 1 forks source link

116 tabs refactoring #121

Closed Metizik closed 5 years ago

Metizik commented 5 years ago

General

Closes #116

Extracted all account voting tabs into separate components and made use of new Tabs from styleguide, added three routes as it was suggested in comments. Checked tabs work against test and mainnet in different colors schemes, compared against previous implementation.

General

Please make sure the following is done:

Pull request is onto develop
If you haven't already, have a look at
- https://github.com/bitshares/bitshares-ui/blob/develop/CODE_OF_CONDUCT.md
- https://github.com/bitshares/bitshares-ui/blob/develop/CONTRIBUTING.md

Code Preparation

Please review all your changes one last time before committing

[x] Check for unused code
[x] No unrelated changes are included
[x] None of the changed files are reformatting only
[x] Code is self explanatory or documented
[x] All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

[x] Chrome
[ ] Opera
[x] Firefox
[ ] Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

[x] Dark
[x] Light
[x] Midnight

Please provide screenshots/licecap of your changes below Screenshot from 2019-06-17 12-07-26

sschiessl-bcp commented 5 years ago

Is this completed? https://github.com/blockchainprojects/bitshares-ui/issues/116#issuecomment-502170007

Metizik commented 5 years ago

Yes, completely

Metizik commented 5 years ago

@sschiessl-bcp , pushed updates with fixes for requested changes

sschiessl-bcp commented 5 years ago

Forwarded