blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain
https://wallet.bitshares.org
MIT License
0 stars 1 forks source link

#130 portfolio sorting issues #131

Closed Metizik closed 5 years ago

Metizik commented 5 years ago

General

Closes #130

The issue was caused by incorrect implementation of the PaginatedList, which is wrapping Table component. This component was reducing data source model of the table to single page items, causing it to work improperly. Initially I tried to apply pre-sorting for the whole data set by price, but it did not work and caused certain performance issues. I replaced PaginatedList with Table component with built-in pagination and it worked just fine.

Regarding this I believe all other components, where PaginatedList is used, should also be refactored since them do have same issues.

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

Testing

The branch has been tested on the following browsers (desktop and mobile view)

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

Please provide screenshots/licecap of your changes below Screenshot from 2019-06-26 15-35-05 Screenshot from 2019-06-26 15-35-12

Metizik commented 5 years ago

@sschiessl-bcp , as it was agreed in IM I changed fix from inlining Table component in Profolio, to valid implementation of wrapping logic in PaginatedList, using Table pagination instead of custom one

sschiessl-bcp commented 5 years ago

Accepted