search

blockchainprojects / bitshares-ui

Graphical User Interface for BitShares Blockchain
https://wallet.bitshares.org
MIT License
0 stars 1 forks source link

2473 dashboard portfolio trade asset bug(reformated) #152

Closed VerevkinAlexander closed 5 years ago

VerevkinAlexander commented 5 years ago

Closes #98 IAdded onMarketChange method on TradingViewPriceChart.jsx start

VerevkinAlexander commented 5 years ago

Please review it

sschiessl-bcp commented 5 years ago

Did you manually test the necessity of all the switchMarket calls? Every call increases the overhead onto the node.

VerevkinAlexander commented 5 years ago

Did you manually test the necessity of all the switchMarket calls? Every call increases the overhead onto the node. yes, I`ve tested them manually. I did not find a solution without using switchMarket call

sschiessl-bcp commented 5 years ago

Please provide a screenshot of every click/link action that required to add switchMarkets.

VerevkinAlexander commented 5 years ago

1 2 3 @sschiessl-bcp

sschiessl-bcp commented 5 years ago

You provided me three screens, but added the switch to over 10 spots in the code. Please elaborate

VerevkinAlexander commented 5 years ago

FormattedPrice

I've done additional testing and found the ways to optimize the solution: some unnecessary function calls which were removed. The bug has been reproduced from four places, so I left the function calls only in these four files and posted four relevant screenshots. Perhaps this problem could be solved in another way, but it will take more time to research.

sschiessl-bcp commented 5 years ago

Done